Another issue with GitHub's pull request model, which encourages you to "push new commits to your branch" rather than rebase to address feedback, is that it treats the pull request itself as the atomic unit of change. Where this falls apart is that, once it gets merged, the information in the pull request is lost, and an uncohesive set of "fixes thing" commits is a poor substitute for anyone browsing the git log.
Reminder that we have a guide to git rebasing that's helpful for avoiding this kind of problem: https://git-rebase.io
@sir I’m not wild about the mode either, but doesn’t changing the merge strategy to ff-only address this?
@sir CVS rulz 😀
@sir GitHub can squash and merge (project setting maybe?), producing a single commit. I suppose, this solves the problem of "fixing things" comments.
The social network of the future: No ads, no corporate surveillance, ethical design, and decentralization! Own your data with Mastodon!