Another issue with GitHub's pull request model, which encourages you to "push new commits to your branch" rather than rebase to address feedback, is that it treats the pull request itself as the atomic unit of change. Where this falls apart is that, once it gets merged, the information in the pull request is lost, and an uncohesive set of "fixes thing" commits is a poor substitute for anyone browsing the git log.

Follow

Reminder that we have a guide to git rebasing that's helpful for avoiding this kind of problem: git-rebase.io

@sir Have you seen this? learngitbranching.js.org/

I've learned a lot from that one. I tend to give it to people.

Also magit, great tool. It made me better at git.

Sign in to participate in the conversation
Mastodon

The social network of the future: No ads, no corporate surveillance, ethical design, and decentralization! Own your data with Mastodon!